Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local file returns as is_file_readable_externally_by_hash() == true if preferexternal is set and file is 0 bytes in size #634

Open
petersistrom opened this issue Sep 16, 2024 · 1 comment

Comments

@petersistrom
Copy link
Contributor

If a local file has a size of 0 bytes and the tool_objectfs | preferexternal setting is turned on, then the is_file_readable_externally_by_hash

if ($contenthash === sha1('')) {
will still return true and the plugin will look for a non-existent external file and return a 404, even though the file exists locally.

@petersistrom
Copy link
Contributor Author

Related to #609

brendanheywood added a commit that referenced this issue Oct 8, 2024
Issue #634: Return external accessible false is file empty or directory
brendanheywood added a commit that referenced this issue Oct 8, 2024
Issue #634: Return external accessible false is file empty or directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant