Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: add info check result mapping #194

Merged
merged 1 commit into from
Sep 15, 2024
Merged

bugfix: add info check result mapping #194

merged 1 commit into from
Sep 15, 2024

Conversation

matthewhilton
Copy link
Contributor

Issue

  • Discovered that result::INFO was not being mapped and hence would output as 'UNKNOWN' which is considered bad, when info isn't actually a bad thing.

Fix

  • Added info to the mapping

Pull request checks

  • I have checked the version numbers are correct as per the README

keevan
keevan approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing that up Matt.

@keevan keevan merged commit 99eaf75 into MOODLE_39_STABLE Sep 15, 2024
30 checks passed
@keevan keevan deleted the info-level branch September 15, 2024 23:06
@brendanheywood brendanheywood mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keevan keevan keevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewhilton @keevan