Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#353] Fix unit tests - strtotime returns incorrect month #355

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

glepod
Copy link

@glepod glepod commented Aug 30, 2024

There is a bug in strtotime() and month subtraction in the last 1-2 days in a month where the result month is February.
Adding a step to use the first day of the month as the source for the strtotime() function resolves this issue.

@keevan keevan merged commit 6cfc56e into catalyst:MOODLE_35_STABLE Aug 30, 2024
21 checks passed
@keevan
Copy link
Contributor

keevan commented Aug 30, 2024

Thanks @glepod :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tool_excimer\tool_excimer_purge_page_group_test::test_purge - Excimer failing in unittest
2 participants