issue #909: use assertObjectHasProperty

catalyst · Nov 14, 2024 · 11e9fa7 · 11e9fa7
1 parent 496d305
commit 11e9fa7
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/tests/tool_dataflows_connector_curl_test.php b/tests/tool_dataflows_connector_curl_test.php
@@ -85,9 +85,9 @@ public function test_execute() {
         $this->assertEquals('3d188fbf-d0b7-4d4e-ae4d-4b5548df824e', $result->uuid);
 
         $this->assertEquals(200, $vars->httpcode);
-        $this->assertObjectHasAttribute('connecttime', $vars);
-        $this->assertObjectHasAttribute('totaltime', $vars);
-        $this->assertObjectHasAttribute('sizeupload', $vars);
+        $this->assertObjectHasProperty('connecttime', $vars);
+        $this->assertObjectHasProperty('totaltime', $vars);
+        $this->assertObjectHasProperty('sizeupload', $vars);
 
         $testurl = $this->get_mock_url('/test_post.php');
 
@@ -115,9 +115,9 @@ public function test_execute() {
         $vars = $engine->get_variables_root()->get('steps.connector.vars');
 
         $this->assertEquals(200, $vars->httpcode);
-        $this->assertObjectHasAttribute('connecttime', $vars);
-        $this->assertObjectHasAttribute('totaltime', $vars);
-        $this->assertObjectHasAttribute('sizeupload', $vars);
+        $this->assertObjectHasProperty('connecttime', $vars);
+        $this->assertObjectHasProperty('totaltime', $vars);
+        $this->assertObjectHasProperty('sizeupload', $vars);
 
         // Tests put method.
         $stepdef->config = Yaml::dump([
@@ -145,9 +145,9 @@ public function test_execute() {
 
         // PUT has no response body so it shouldn't be checked.
         $this->assertEquals(200, $vars->httpcode);
-        $this->assertObjectHasAttribute('connecttime', $vars);
-        $this->assertObjectHasAttribute('totaltime', $vars);
-        $this->assertObjectHasAttribute('sizeupload', $vars);
+        $this->assertObjectHasProperty('connecttime', $vars);
+        $this->assertObjectHasProperty('totaltime', $vars);
+        $this->assertObjectHasProperty('sizeupload', $vars);
 
         $expectedbash = "curl -s -X PUT {$testurl} --max-time 30 --data-raw 'data=moodletest'";
         $this->assertEquals($expectedbash, $variables->dbgcommand);