fix: handle null values in array_reverse call #27 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriim
reviewed
Oct 24, 2024
| $this->definition->rubric_criteria[$rcid]['levels'] = | ||
| array_reverse($this->definition->rubric_criteria[$rcid]['levels'], true); | ||
| foreach ($this->definition->rubric_criteria as $rcid => $criteria) { | ||
| if (!empty($criteria['levels']) && is_array($criteria['levels'])) { |
There was a problem hiding this comment.
In what use cases $criteria['levels'] can be empty or not an array?
|
@rajandangi thank you for submitting a patch. As it's missing automated tests, can you please provide some manual testing instructions to verify that the patch works as intended? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a type check to ensure $criteria['levels'] is set and is an array before using array_reverse.
Closes #27