Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When prebaking the static theme file, handle redirects #234

Closed
brendanheywood opened this issue Jan 30, 2021 · 1 comment · Fixed by #255
Closed

When prebaking the static theme file, handle redirects #234

brendanheywood opened this issue Jan 30, 2021 · 1 comment · Fixed by #255

Comments

@brendanheywood
Copy link
Contributor

ie if a theme uses a file, the file normally is served as a redirect to s3 signed url. It is very likely this is getting broken somehow.

The symptoms are that this file is not being served using the static file.php, so it ends up going to a real script which then gets diverted to the outage page
@brendanheywood
Copy link
Contributor Author

The root cause is this in outage page:

<div class="header-banner" style="background-image: url(https://xxxxxxx.xxx.edu/pluginfile.php/1/theme_xxx/banner/576336053/connections-abstract-fuschia-micro-banner.jpg)">

The pre-baker process is not correctly picking up this inline file reference and changing it to /auth/outage/file.php url

yao9394 pushed a commit to yao9394/moodle-auth_outage that referenced this issue Feb 12, 2021
Fix catalyst#234 pick up images from inline style background image
c865848
@brendanheywood brendanheywood mentioned this issue Feb 26, 2021
Open
katerynadegtyariova pushed a commit to katerynadegtyariova/moodle-auth_outage that referenced this issue May 20, 2021
@katerynadegtyariova
Fix catalyst#234 pick up images from inline style background image
5285c4d
katerynadegtyariova added a commit that referenced this issue May 24, 2021
@katerynadegtyariova
Fix #234 pick up images from inline style background image.
1f2eea1 
Added a new unit test test_update_inline_background_images.
katerynadegtyariova added a commit that referenced this issue May 24, 2021
@katerynadegtyariova
Fix #234 pick up images from inline style background image.
e8dddfd
katerynadegtyariova added a commit that referenced this issue May 24, 2021
@katerynadegtyariova
Fix #234 pick up images from inline style background image.
8e7d582
katerynadegtyariova added a commit that referenced this issue May 24, 2021
@katerynadegtyariova
Fix #234 pick up images from inline style background image.
92cb858
@katerynadegtyariova katerynadegtyariova mentioned this issue May 25, 2021
Merged
katerynadegtyariova added a commit that referenced this issue May 31, 2021
@katerynadegtyariova
Fix #234 pick up images from inline style background image.
e79f6d5
katerynadegtyariova added a commit that referenced this issue May 31, 2021
@katerynadegtyariova
Fix #234 pick up images from inline style background image.
17463f0
brendanheywood added a commit that referenced this issue May 31, 2021
@brendanheywood
Merge pull request #255 from catalyst/MOODLE_39_STABLE-fix-234-inline…
45987b9 
…-background-image

Fix #234 pick up images from inline style background image.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #234 pick up images from inline style background image. catalyst/moodle-auth_outage
1 participant
@brendanheywood