-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add censusfips metadata #4006
Merged
add censusfips metadata #4006
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fcdebb2
add censusfips metadata
cmgosnell d0b4c0c
Merge branch 'main' into fips-fix
e-belfer 3b14928
change fips dataset name
cmgosnell e38b422
Update src/pudl/metadata/sources.py
cmgosnell 22c2d50
Merge branch 'main' into fips-fix
cmgosnell cfa402e
Add extractor - currently using sandbox doi
cmgosnell 6f18f82
Merge branch 'main' into fips-fix
e-belfer 932ab34
remove the extraction step from this pr
cmgosnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a good flag! but since for now we are only planning on using the one freshest year i think it should only be 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we anticipate updating our fipsification to deal with the time variability of these mappings? There'll definitely be inconsistencies in any individual vintage if we apply it across all years of data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the plan for this issue rn is to effectively replicate addfips which is to say use one vintage. This vintage will be much more recent (2023 instead of addfips most recent 2015). It should be pretty easy with this overall setup to add the additional vintages as a next step.