Bump GDAL to 3.9.0 explicitly to align with PUDL dependencies #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaneselvans
changed the title
|
Ah. This appears to be totally unrelated to GDAL: tox-dev/filelock#337 |
zaneselvans
commented
Jun 12, 2024
| "dask<2024.6", # Temporary pin -- conda packaging problem upstream | ||
| "dask>=2024", |
There was a problem hiding this comment.
This temporary problem went away, and I needed to change the hash of pyproject.toml to clear the environment cache, which had the bad version of a package stuck in it.
| @@ -26,7 +26,6 @@ jobs: | |||
| condarc: | | |||
| channels: | |||
| - conda-forge | |||
| - defaults | |||
There was a problem hiding this comment.
conda / mamba recommends not including the default anaconda channel for package consistency.
| @@ -11,5 +11,6 @@ dependencies: | |||
| # TODO: we shouldn't have to install all this geo stuff, so once we break the | |||
| # dependency on `pudl` we should remove this too. | |||
| - fiona>=1.9.5 | |||
| - gdal>=3.9.0 | |||
There was a problem hiding this comment.
Force the environment to install the most recent GDAL.
| @@ -46,7 +46,7 @@ commands = | |||
| pre-commit run --all-files --show-diff-on-failure name-tests-test | |||
|
|
|||
| [testenv:linters] | |||
| description = Run the pre-commit, flake8 and bandit linters. | |||
| description = Run the pre-commit and ruff linters. | |||
There was a problem hiding this comment.
Out of date description.
pudlbot
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
GDAL 3.9.0 has been out for a while, but the dependency between PUDL and the archivers kept us from updating. Trying to resolve these incompatibilities in this PR.
I think that the PUDL PR updating the dependency needs to merge before the CI on this PR can pass.
Testing
How did you make sure this worked? How can a reviewer verify this?
To-do list
Tasks