Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put authentication in front of GTFS/Editor API endpoints #93

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

landonreed
Copy link
Member

@landonreed landonreed commented Jun 8, 2018

Fixes #92. This PR also adds comments to the GraphQL and main classes.

@landonreed landonreed requested a review from evansiroky June 8, 2018 17:30

// core controllers
// Initialize GTFS GraphQL API service
// FIXME: Add user permissions check to ensure user has access to feeds.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create another issue for this item to make sure it gets done.

Copy link

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue as noted, but making the GraphQL endpoints more secure is a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants