Partially jsonified mine mapgen #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn, the mine code is clunky. I saw at least 2 tentacle dogs and one amigara in one mine. |
|
Tentacle dog is the last thing left for jsonify. After I'm done with it, I'll remove the hardcoded part altogether, and it will naturally remove dupes of mine finales. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Partially jsonified mine mapgen."
Purpose of change
To add my rework of mine entrance, spiral and amigara mines from DDA to BN.
Describe the solution
Added my rework from several DDA's PRs related to mine jsonify.
Specifically:
Full details could be found in the following PRs.
CleverRaven/Cataclysm-DDA#47790
CleverRaven/Cataclysm-DDA#47928
CleverRaven/Cataclysm-DDA#48003
CleverRaven/Cataclysm-DDA#50592
CleverRaven/Cataclysm-DDA#51167
I had to made several changes while porting because in BN there ain't some features that exist in DDA, most notably ramps mechanics.
Describe alternatives you've considered
None.
Testing
Debug-spawned and naturally found several mines, checked if there are errors popping up.
Additional context
This is a big PR to review, but all changes were thoroughly tested while I was working on them in DDA, and also several months passed after they were merged in DDA, and no problems seems to happen, so I think there's no reason to split it up to smaller pieces.