Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stinger dagger no longer uses nonexistent on-hit spell, other consistency fixes for monster weapons #5706

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

chaosvolt
Copy link
Member

Checklist

Required

Optional

Purpose of change

A few consistency fixes and updates set aside for monster hunter weapons.

Describe the solution

  1. Gave sharktooth leiomano fine cutting 1, same as razor macuahuitl, since it was overriding the regular version only to give it the same qualities.
  2. Set stinger dagger to use the same weight and damage modifiers other monster hunter weapons tend to use instead of being identical to the dagger it inherits from.
  3. Removed hammering quality from recipes for stinger arrows/bolts to be consistent with stinger dagger recipe.
  4. Moved fix for stinger dagger's on-hit spell not actually existing from feat(balance): add support for DoT poison ammo effect, rebalance poison effects and sources accordingly #5704 so it can hopefully get merged sooner. No sense having it tied in with a heavier balance tweak.

Describe alternatives you've considered

Removing hammering from tooth recipes because why are you knapping teeth? Also the sharktooth cestus doesn't use it...

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build.
  3. Re-tested stinger dagger to once again confirm the on-hit effect triggers.

Additional context

@RoyalFox2140 RoyalFox2140 merged commit 3ab0ab0 into cataclysmbnteam:main Nov 13, 2024
9 checks passed
@chaosvolt chaosvolt deleted the lil-mh-weap-tweaks branch November 13, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants