Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Large building new apartment start scenario #5683

Merged

Conversation

LucioFurnari
Copy link
Contributor

Checklist

Required

Optional

Purpose of change

I decided to add a new start to the apartment, since it seemed strange to only be able to appear on the roof, and not inside a house.

Describe the solution

Add a new start to the stage by choosing one of the apartment floors.

Describe alternatives you've considered

Testing

I tried several times, and it always appears in a house in the apartment, in general a zombie never spawns inside the house.

Additional context

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Nov 7, 2024
Copy link
Collaborator

@RoyalFox2140 RoyalFox2140 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you added in that 210 damage change by accident

@RoyalFox2140 RoyalFox2140 changed the title (balance) Large building new apartment start scenario feat(balance): Large building new apartment start scenario Nov 7, 2024
@LucioFurnari
Copy link
Contributor Author

Yes, I'm sorry, I don't know why that change was added.

@RoyalFox2140
Copy link
Collaborator

Yes, I'm sorry, I don't know why that change was added.

Your first commit carried over the explosive change, likely from another branch.

@LucioFurnari
Copy link
Contributor Author

How i can remove that change, I don't know how it appeared

@RoyalFox2140
Copy link
Collaborator

How i can remove that change, I don't know how it appeared

I just put the original number back for you, I don't really mess with Github CLI and proper reverts that much.

@RoyalFox2140 RoyalFox2140 self-requested a review November 7, 2024 23:54
@LucioFurnari
Copy link
Contributor Author

Thanks, and sorry for the commit, I didn't know what happened.

@scarf005 scarf005 changed the title feat(balance): Large building new apartment start scenario feat: Large building new apartment start scenario Nov 8, 2024
@scarf005
Copy link
Member

scarf005 commented Nov 8, 2024

nitpick: this doesn't seem to be a balance change. otherwise looks good

@RoyalFox2140 RoyalFox2140 merged commit 209a9fa into cataclysmbnteam:main Nov 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants