Misc tweaks for tests #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The creature_test tests were still using srand to seed the RNG. This serves no purpose now since we don't use rand for randomness. Moreover, it was causing the tests to fail more often than they used to when this mattered. Switch these tests over to rng_set_engine_seed instead, and expand the existing clang-tidy check looking for uses of rand to also flag uses of srand (and similar library randomness functions).
This test is rather slow, and doesn't test anything that isn't fairly well-tested by other tests. Delete it to save time.
Without this, this test run in isolation would fail. I'm not sure what aspect of the extra clearing code is needed.
This test could fail when run in isolation. This fixes that.
Call player::environmental_revert_effect to remove addictions to e.g. prevent opiate withdrawal from causing unexpected random pain in tests.
Coolthulhu
reviewed
Dec 17, 2020
Coolthulhu
reviewed
Dec 17, 2020
|
For some reason, my tests are now taking 50% more time (200s -> 300s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Misc changes for tests aimed at QoL / speed / correctness.
Might fix some of these order-dependent failures.
Describe the solution
Cherry-picked from DDA:
CleverRaven#44910
CleverRaven#44636
CleverRaven#44281
CleverRaven#44286
CleverRaven#40359
CleverRaven#43255
CleverRaven#43290
CleverRaven#40674
Testing
Let's see what travis thinks about it