pass point by value
#2461
Merged
pass point by value
#2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
changed the title
point by valuepoint by value (~13% performance improvement)
scarf005
changed the title
point by value (~13% performance improvement)point by value
size of point of value and point pointer is same (8 bytes). therefore passing point by value may improve performance.
scarf005
force-pushed
the
point-as-value
branch
from
b9c51d9
to
d1bbba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Pass point by value"
Purpose of change
point only have two int member, x and y. that makes its size 8 bytes (64bit), the same size as pointer address in 64bit machine. passing value directly is faster for points because references needs to be dereferenced.
Describe the solution
regex-replace
const point &topoint. couldn't changepoint_traits.hcause it uses references and cause weird ambiguities.Describe alternatives you've considered
become average slow life enjoyer
Testing
had a break with debug monsters. it was on max ~13% faster. it could be due to other reasons, such as background processes, but gotta be optimistic here.
Additional context
.cppfiles #2457