Misc UI changes/fixes from mainline #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use number formats for average melee damage This slightly changes the "Average melee damage" section of the item info display panel, to put the labels first, and use <num> formatting for the bash/cut/pierce damage and critical hit values. A desired effect of this change is that the item comparison window will now highlight those numbers in green or red when they are better or worse than the other item. * Use distinct critical hit labels Labeling these uniquely, as "Critical bash", "Critical cut", and "Critical pierce", allows their numerical values to be compared appropriately instead of being treated the same for all damage types.
|
That bandit hiding thing isn't perfect, though. Ideally, it would be uncovered when the player gets close enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Port various UI improvements from DDA"
Purpose of change
Small stuff for UI usability/consistency/correctness
Describe the solution
CleverRaven#44720
CleverRaven#40087 (made sure it works with 'no lift requirements' mod)
CleverRaven#40276
CleverRaven#40539
CleverRaven#40784
CleverRaven#40561 (ported only useful stuff)
CleverRaven#41102 (doesn't show up if player has low melee skill)
CleverRaven#41195
CleverRaven#41290
CleverRaven#41407 (weapon name erroneously extends onto next line in BN, so this fix still applies)
Describe alternatives you've considered
Testing
Tested each of them briefly to make sure the game doesn't crash and the change actually works.
Additional context