-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ Add Stalker UI and functionality #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds stalker bool to be used for checking.
Adds stalker component which contains buttons for each chatting pair. Also adds test data to be used for testing.
…-me-if-you-can into nathanjumaah-stalker
…onym-team/cat-me-if-you-can into nathanjumaah-stalker
Adds stalker being sent to their proper component in games page.svelte
…-me-if-you-can into nathanjumaah-stalker
remove test data from temp page as 1 on 1 chat should be available soon.
adds tests for stalkchatroom for security
Adds getChatRoomCollection to be used in stalker.ts for setting the stalker as spectator.
adds path to stalker in index.ts
created stalker.ts
fixes stalker.svelte to be used for when 1 on 1 chat is merged
…eam/cat-me-if-you-can into nathanjumaah-stalker
cleaning code from merge with giantte branch.
…eam/cat-me-if-you-can into nathanjumaah-stalker
updates chatroom declaration in stalker.svelte and stalker call in game page.svelte
removes a redundant import in stalker.svelte
update and delete stalker bool on generating pair and deleting chat
subscribe/unsubscribe from chatroom
add firestore rule to update stalker boolean in private players
update firestore rules for isStalker()
add chatroomIds collection and attempt to use ids for the buttons (does not work)
add comment for StalkChatroomRequest type
change LobbyRequest input to StalkChatroomRequest input for stalkChatroom in firestore-functions
…-me-if-you-can into nathanjumaah-stalker
fix private player not includingthe stalker bool in a call
change the transaction update to look at the ref for chatrooms instead of lobby
load chatroom in stalker.svelte (does not work atm)
update stalker component to get rid of console log and work
fix chatroom in page.svelte call so it works with new parameters
njumaah
previously approved these changes
Nov 8, 2022
5 tasks
5 tasks
gchamb
requested changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
/**
* Checks if the user is in a chatroom then returns their chatroom doc
*/
export async function findChatRoom(lobbyId: string, playerId: string) {
const queryChatRoom = await getDocs(query(getChatRoomCollection(lobbyId), where("pair", "array-contains", playerId)));
return queryChatRoom.docs[0];
}
export async function findViewerChatRoom(lobbyId: string, viewerId: string) {
const queryChatRoom = await getDocs(
query(getChatRoomCollection(lobbyId), where("viewers", "array-contains", viewerId))
);
return queryChatRoom.docs[0];
} in chat.ts delete this pls |
…-me-if-you-can into nstringham/material-stalker
gchamb
requested changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix build checks
this is just because girhub is bieng weird and I want to see what happens if I make a commit
gchamb
previously approved these changes
Nov 9, 2022
gchamb
approved these changes
Nov 9, 2022
4 tasks
4 tasks
This was
linked to
issues
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all the changes from #65 but also contains some improvements and some Material and CSS
note that this PR does not complete #34 because it does not complete this criteria