deps: Update rbs to 3.0 #662
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "set" has been merged into the Ruby Core and RBS has been drop support since v3.0. So current spec implementation will not work with RBS-3.x.
|
@castwide any reservation to update to |
|
Hey @tk0miya / @castwide, is there anything holding this from being shipped? This is kinda blocking merging https://gitlab.com/gitlab-org/gitlab/-/merge_requests/157114#note_1982725864 Thanks! |
|
No problem from my side. I'm also waiting to merge this to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now solargraph depends on RBS-2.x. So we can't use Solargraph and the latest RBS. So this updates the dependency to RBS 3.0. What do you think?