Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Java 11 #743

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Upgrade to Java 11 #743

merged 4 commits into from
Jul 11, 2019

Conversation

lintool
Copy link
Member

@lintool lintool commented Jul 11, 2019

Let's just do it...

@lintool
Copy link
Member Author

lintool commented Jul 11, 2019

On this branch, if I want to still use JDK8, this appears to work fine in pom.xml:

-          <source>11</source>
-          <target>11</target>
-          <testSource>11</testSource>
-          <testTarget>11</testTarget>
+          <source>8</source>
+          <target>8</target>
+          <testSource>8</testSource>
+          <testTarget>8</testTarget>

Robust04 regression works fine.

Since this is technically @r-clancy PR, @emmileaf should review...

emmileaf
emmileaf reviewed Jul 11, 2019
View reviewed changes
Copy link
Member

@emmileaf emmileaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though should we also update the readme to explain this change?

@lintool
Copy link
Member Author

lintool commented Jul 11, 2019

@emmileaf yes, I'll do it. I'll prepare the README change before merging this.

@lintool
Copy link
Member Author

lintool commented Jul 11, 2019

Actually, I need to merge this to get the commit id to put in the README. Merging.

@lintool lintool merged commit 17b702d into master Jul 11, 2019
@lintool lintool deleted the java-11 branch July 11, 2019 14:41
Victor0118 added a commit to Victor0118/Anserini that referenced this pull request Jul 16, 2019
@Victor0118
Revert "Upgrade to Java 11 (castorini#743)"
0eabf20 
This reverts commit 17b702d.
@lintool lintool mentioned this pull request Jul 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmileaf emmileaf emmileaf approved these changes

@ryan-clancy ryan-clancy Awaiting requested review from ryan-clancy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lintool @emmileaf