-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multi-threaded Batch Document #1857
Conversation
Hi, @lintool I have a PR in progress. I need your thoughts on some things:
|
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
============================================
+ Coverage 57.70% 57.71% +0.01%
- Complexity 1055 1058 +3
============================================
Files 179 179
Lines 10232 10250 +18
Branches 1407 1409 +2
============================================
+ Hits 5904 5916 +12
- Misses 3836 3841 +5
- Partials 492 493 +1
Continue to review full report at Codecov.
|
hi @HAKSOAT - thanks for this PR. Let's go with a single method for now, called If you update and merge in current master, it should get rid of the new markdown edits? Thanks! |
lg, but can you please build a fatjar, copy over to pyserini, and make sure it connects up on the pyserini end? i.e., let's build the bindings on the pyserini end just to confirm everything works e2e. |
Noted. |
It works. I'll put a PR through for this on Pyserini. |
This addresses #1778