-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arthur replication #1509
Arthur replication #1509
Conversation
OS: Ubuntu 18.04 bionic Results are the same: ``` map all 0.2789 recall_1000 all 0.9326 ```
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
=========================================
Coverage 57.27% 57.27%
Complexity 978 978
=========================================
Files 166 166
Lines 9101 9101
Branches 1231 1231
=========================================
Hits 5213 5213
Misses 3498 3498
Partials 390 390 Continue to review full report at Codecov.
|
docs/experiments-msmarco-doc.md
Outdated
@@ -212,3 +212,4 @@ That's it! | |||
+ Results replicated by [@KaiSun314](https://github.com/KaiSun314) on 2021-01-08 (commit [`113f1c7`](https://github.com/castorini/anserini/commit/113f1c78c3ffc8681a06c571901cf9ad8f5ee633)) | |||
+ Results replicated by [@yemiliey](https://github.com/yemiliey) on 2021-01-18 (commit [`179c242`](https://github.com/castorini/anserini/commit/179c242562bbb990e421f315370f34d4d19bbb9f)) | |||
+ Results replicated by [@larryli1999](https://github.com/larryli1999) on 2021-01-22 (commit [`3f9af5`](https://github.com/castorini/anserini/commit/3f9af54d6215eacbade7fc99ff8890920fdddee0)) | |||
+ Results replicated by [@ArthurChen189](https://github.com/ArthurChen189) on 2021-04-08 (commit [`d43b5c6`](https://github.com/castorini/anserini/commit/b0e0092fb4c4f2bf053c9e5d35b63aca6fd30e47)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs/experiments-msmarco-passage.md
Outdated
@@ -189,3 +189,4 @@ To replicate these results, the `SearchMsmarco` class above takes `k1` and `b` p | |||
+ Results replicated by [@KaiSun314](https://github.com/KaiSun314) on 2021-01-08 (commit [`113f1c7`](https://github.com/castorini/anserini/commit/113f1c78c3ffc8681a06c571901cf9ad8f5ee633)) | |||
+ Results replicated by [@yemiliey](https://github.com/yemiliey) on 2021-01-18 (commit [`179c242`](https://github.com/castorini/anserini/commit/179c242562bbb990e421f315370f34d4d19bbb9f)) | |||
+ Results replicated by [@larryli1999](https://github.com/larryli1999) on 2021-01-22 (commit [`3f9af5`](https://github.com/castorini/anserini/commit/3f9af54d6215eacbade7fc99ff8890920fdddee0)) | |||
+ Results replicated by [@ArthurChen189](https://github.com/ArthurChen189) on 2021-04-07 (commit [`6fca6df`](https://github.com/castorini/anserini/commit/6fca6dfb50f446972813f76257a64c06bc1b6903)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will resubmit a pr. Thanks
passage and doc .md updated and ready to be merged. |
I don't think the "This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository." issue has been resolved... |
@ArthurChen189 the commit id in the reproduction log should be: the last commit ID on the master branch (not a commit from a branch in your forked repo.) |
Thanks for your suggestion. What I did was that I forked the repo and then created a new branch under my forked repo. I committed to adding "results replicated ..." at the bottom of the ".md" without commit id first,
and then added the previous commit id to my "results replicated ..." and made another commit.
Yes. it is based on the newest version. |
@ArthurChen189 Yes, if so, the replication log are expected to be:
Our purpose of replication log is to record the latest version of our main repo that confirmed "working" |
I see, then should I use exactly the same commit id for all replications then? |
OS: Ubuntu 18.04 bionic
Results are the same:
passage:
doc: