Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replication for elastrini and solrini #1226

Merged
merged 2 commits into from
May 28, 2020
Merged

Replication for elastrini and solrini #1226

merged 2 commits into from
May 28, 2020

Conversation

shaneding
Copy link
Contributor

  • General: Had to use ./bin/qbuild.sh rather than the mvn clean package appassembler:assemble given in the docs (not sure if its just me or a general issue)

Elastrini and Solrini:

  • MS MARCO Passage: No issues, but retrieval takes really long, maybe create shorter file just for replication, like in the original MS MARCO passage replication?

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #1226 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1226      +/-   ##
============================================
- Coverage     48.32%   48.28%   -0.04%     
+ Complexity      738      736       -2     
============================================
  Files           147      147              
  Lines          8559     8559              
  Branches       1217     1217              
============================================
- Hits           4136     4133       -3     
- Misses         4083     4087       +4     
+ Partials        340      339       -1     
Impacted Files Coverage Δ Complexity Δ
...java/io/anserini/ltr/feature/CountBigramPairs.java 83.11% <0.00%> (-3.90%) 29.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ecfa4...0b9793b. Read the comment docs.

@lintool
Copy link
Member

lintool commented May 26, 2020

  • General: Had to use ./bin/qbuild.sh rather than the mvn clean package appassembler:assemble given in the docs (not sure if its just me or a general issue)

What's your env setup? OS, Java version, etc. What errors are you getting?

@shaneding
Copy link
Contributor Author

Environment
OS: macOS 10.15 (Catalina)
Java: 14.0.1
Python: 3.7.6

Error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test (default-test) on project anserini: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? -> [Help 1]

@lintool
Copy link
Member

lintool commented May 26, 2020

@shaneding

Java: 14.0.1

That's the issue... I think this is a known issue - #1198

@shaneding
Copy link
Contributor Author

Okay, so should ./qbuild.sh be used in place of "mvn clean package appassembler:assemble" for now?

@lintool
Copy link
Member

lintool commented May 28, 2020

@shaneding I think the cleaner solution would be for you to downgrade to Java 11 so that you can stay in sync with the project... so you won't run into other JVM compat issues down the road...

@lintool lintool merged commit f3bf7d2 into castorini:master May 28, 2020
crystina-z pushed a commit to crystina-z/anserini that referenced this pull request Oct 28, 2022
…ini#1226)

* Updated script to run with the SpacyNER tagger and REL linker. It is RAM intensive

* Shortened left/right context creation into a one-liner. Corrected indentation from tabs to spaces

* Added safeguard to keep documents without entities in the final collection file. Fixed positions that refer to the original position of the mentions in the original text.

Co-authored-by: Gustavo Gonçalves <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants