Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed namespace issue if element is defined in based schema #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed namespace issue if element is defined in based schema #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion xml/src/main/java/org/exolab/castor/xml/UnmarshalHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,9 +711,16 @@ public void startElement(String namespaceURI, String localName, String qName, At
// check for default namespace declaration
String defaultNamespace = _namespaceHandling.getDefaultNamespaceURI();
// TODO[WG]: remove unnecessary check as it simply is wrong
/* Eason Xiao - This logic is wrong. The namespaceURI might be different to defaultNamespace, for example :
An element is defined in base schema, this element has a different namespace.
if (defaultNamespace != null && !defaultNamespace.equals("http://castor.exolab.org")) {
namespaceURI = defaultNamespace;
namespaceURI = defaultNamespace;
}*/
// Eason Xiao - change commented code above to below :
if (namespaceURI == null && defaultNamespace != null && !defaultNamespace.equals("http://castor.exolab.org")) {
namespaceURI = defaultNamespace;
}

// -- adjust empty namespace
if (StringUtils.isEmpty(namespaceURI))
namespaceURI = null;
Expand Down