Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sourcelink and Deterministic Build #669

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

304NotModified
Copy link

@304NotModified 304NotModified commented Sep 27, 2023

This PR enables Source Link and Deterministic Builds.

Why

  • Source Link so that users could debug the library from their Visual Studio
  • Deterministic Build to be sure that the produced binary on nuget.org is really made from this Github Source

Most of the top NuGet packages has enabled Source Link. Also some are using Deterministic Build.

E.g. Newtonsoft.Json

image

I've also configured deterministic builds for other open-source projects, e.g. nunit/nunit#3810, App-vNext/Polly#839

More info

Before

(Checked with https://github.com/NuGetPackageExplorer/NuGetPackageExplorer)

image
image
image
image

After

TODO

Note, no signature because this is from local. You could also see this by downloading the .nugpkg and .snupkg from the artifacts from AppVeyor

Note! the .snukpg should be published to nuget.org, otherwise the source link won't work

Note

AFAIK the nuget push on
https://github.com/castleproject/Core/blob/f937cc1a766250772d1a6f582fab1d11594591c2/appveyor.yml#L69C1-L72C158
will also push the snupkg (and that's good!)

TODO

  • Update screenshot after
  • Wait for build results
  • Screenshots for all the packages

@stakx
Copy link
Member

stakx commented Sep 27, 2023

Hi @304NotModified and thanks for working on this. I am going to take a closer look soon. In the meantime, could you take a look at a previous (but unmerged) SourceLink PR #524 and see how much of the review comments there may still apply here too? Thanks!

@304NotModified
Copy link
Author

304NotModified commented Sep 28, 2023

Will do, probably after this weekend!

I will undraft this PR when it's ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants