Remove DictionaryAdapter #468
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stakx if you drew that, nice work 🥇. I couldn't draw to save my life. |
|
No, no, I cannot claim to have invented Trogdor (though I wish I had). 😄 |
|
I'm going to close this one too, for now. While I think it would be great to archive DA rather sooner than later, the world will probably keep spinning even if this doesn't happen for Castle.Core v5. We can always reactivate this PR when it's needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #394. It complements
castleproject/DictionaryAdapter#1🚧 and does the fun bit:Some things that need to be done outside of this PR:
Update this repo's summary:
Update the DictionaryAdapter link on the Castle Project homepage to no longer point at this repo.(Update: Created a separate PR for this.)