Bd/master label accessible buttons (#606)

* add labels to buttons * Add aria-labels to some buttons
castlecms · Jul 12, 2024 · 9cfe163 · 9cfe163
1 parent 6af5d74
commit 9cfe163
Show file tree

Hide file tree

Showing 6 changed files with 74 additions and 18 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -4,7 +4,7 @@ Changelog
 3.0.0b141 (unreleased)
 ----------------------
 
-- Nothing changed yet.
+- Add aria-labels to some buttons
 
 
 3.0.0b140 (2024-07-12)

diff --git a/castle/cms/static/components/add-content-modal.js b/castle/cms/static/components/add-content-modal.js
@@ -294,7 +294,12 @@ define([
         title += ' ' + this.state.selectedType.title;
       }
       return [
-        D.button({ type: 'button', className: 'close', 'data-dismiss': 'modal'}, [
+        D.button({
+          type: 'button',
+          className: 'close',
+          'data-dismiss': 'modal',
+          'aria-label': 'Dismiss Modal'
+        }, [
           D.div({ className: 'close-button' }),
           D.span({ 'aria-hidden': 'true' }, '\u00d7')
         ]),
@@ -718,7 +723,12 @@ define([
         title += ' ' + this.state.selectedType.title;
       }
       return [
-        D.button({ type: 'button', className: 'close', 'data-dismiss': 'modal'}, [
+        D.button({
+          type: 'button',
+          className: 'close',
+          'data-dismiss': 'modal',
+          'aria-label': 'Close Modal'
+        }, [
           D.div({ className: 'close-button' }),
           D.span({ 'aria-hidden': 'true' }, '\u00d7')
         ]),
@@ -768,7 +778,12 @@ define([
                                 onClick: this.createAndEditClicked, disabled: disabled }, 'Create and Edit'));
         }
       }else{
-        buttons.push(D.button({ type: 'button', className: 'plone-btn plone-btn-primary', 'data-dismiss': 'modal' }, 'Done'));
+        buttons.push(D.button({
+          type: 'button',
+          className: 'plone-btn plone-btn-primary',
+          'data-dismiss': 'modal',
+          'aria-label': 'Dismiss Modal',
+        }, 'Done'));
       }
       var contentList = '';
       if(this.state.createdContent.length > 0){

diff --git a/castle/cms/static/components/upload.js b/castle/cms/static/components/upload.js
@@ -351,12 +351,20 @@ define([
           D.button({ className: 'btn btn-default castle-btn-edit', onClick: that.editImageClicked }, 'Edit Image'));
       }
       buttons.push(
-        D.button({ className: 'plone-btn plone-btn-default castle-btn-remove', onClick: that.removeClicked },
+        D.button({
+          className: 'plone-btn plone-btn-default castle-btn-remove',
+          onClick: that.removeClicked,
+          'aria-label': 'Remove',
+        },
           D.span({ className: 'icon-remove' }))
       );
       buttons.push(
-        D.button({ className: 'plone-btn plone-btn-default castle-btn-upload',
-                   onClick: that.approveClicked, disabled: !canApprove },
+        D.button({
+          className: 'plone-btn plone-btn-default castle-btn-upload',
+          onClick: that.approveClicked,
+          disabled: !canApprove,
+          'aria-label': 'Upload',
+      },
           D.span({ className: 'icon-ok' }))
       );
 
@@ -750,7 +758,12 @@ define([
 
     renderHeader: function(){
       return [
-        D.button({ type: 'button', className: 'close', 'data-dismiss': 'modal'}, [
+        D.button({
+          type: 'button',
+          className: 'close',
+          'data-dismiss': 'modal',
+          'aria-label': 'Dismiss Modal',
+        }, [
           D.div({ className: 'close-button' }),
           D.span({ 'aria-hidden': 'true' }, '\u00d7')
         ]),

diff --git a/castle/cms/static/plone-logged-in-compiled.js b/castle/cms/static/plone-logged-in-compiled.js
@@ -22710,12 +22710,20 @@ define('castle-url/components/upload',[
           D.button({ className: 'btn btn-default castle-btn-edit', onClick: that.editImageClicked }, 'Edit Image'));
       }
       buttons.push(
-        D.button({ className: 'plone-btn plone-btn-default castle-btn-remove', onClick: that.removeClicked },
+        D.button({
+          className: 'plone-btn plone-btn-default castle-btn-remove',
+          onClick: that.removeClicked,
+          'aria-label': 'Remove',
+        },
           D.span({ className: 'icon-remove' }))
       );
       buttons.push(
-        D.button({ className: 'plone-btn plone-btn-default castle-btn-upload',
-                   onClick: that.approveClicked, disabled: !canApprove },
+        D.button({
+          className: 'plone-btn plone-btn-default castle-btn-upload',
+          onClick: that.approveClicked,
+          disabled: !canApprove,
+          'aria-label': 'Upload',
+      },
           D.span({ className: 'icon-ok' }))
       );
 
@@ -23109,7 +23117,12 @@ define('castle-url/components/upload',[
 
     renderHeader: function(){
       return [
-        D.button({ type: 'button', className: 'close', 'data-dismiss': 'modal'}, [
+        D.button({
+          type: 'button',
+          className: 'close',
+          'data-dismiss': 'modal',
+          'aria-label': 'Dismiss Modal',
+        }, [
           D.div({ className: 'close-button' }),
           D.span({ 'aria-hidden': 'true' }, '\u00d7')
         ]),
@@ -23495,7 +23508,12 @@ define('castle-url/components/add-content-modal',[
         title += ' ' + this.state.selectedType.title;
       }
       return [
-        D.button({ type: 'button', className: 'close', 'data-dismiss': 'modal'}, [
+        D.button({
+          type: 'button',
+          className: 'close',
+          'data-dismiss': 'modal',
+          'aria-label': 'Dismiss Modal'
+        }, [
           D.div({ className: 'close-button' }),
           D.span({ 'aria-hidden': 'true' }, '\u00d7')
         ]),
@@ -23919,7 +23937,12 @@ define('castle-url/components/add-content-modal',[
         title += ' ' + this.state.selectedType.title;
       }
       return [
-        D.button({ type: 'button', className: 'close', 'data-dismiss': 'modal'}, [
+        D.button({
+          type: 'button',
+          className: 'close',
+          'data-dismiss': 'modal',
+          'aria-label': 'Close Modal'
+        }, [
           D.div({ className: 'close-button' }),
           D.span({ 'aria-hidden': 'true' }, '\u00d7')
         ]),
@@ -23969,7 +23992,12 @@ define('castle-url/components/add-content-modal',[
                                 onClick: this.createAndEditClicked, disabled: disabled }, 'Create and Edit'));
         }
       }else{
-        buttons.push(D.button({ type: 'button', className: 'plone-btn plone-btn-primary', 'data-dismiss': 'modal' }, 'Done'));
+        buttons.push(D.button({
+          type: 'button',
+          className: 'plone-btn plone-btn-primary',
+          'data-dismiss': 'modal',
+          'aria-label': 'Dismiss Modal',
+        }, 'Done'));
       }
       var contentList = '';
       if(this.state.createdContent.length > 0){
@@ -100968,5 +100996,5 @@ require([
   }
 });
 
-define("/Users/brian.duncan/fbigov-dev-repos/quality-check-backend-url-castle-only-master/castle/cms/static/plone-logged-in.js", function(){});
+define("/Users/brian.duncan/fbigov-dev-repos/quality-check-backend-url-castle-only/castle/cms/static/plone-logged-in.js", function(){});
 
diff --git a/castle/cms/static/plone-logged-in-compiled.min.js b/castle/cms/static/plone-logged-in-compiled.min.js
diff --git a/castle/cms/static/plone-logged-in-compiled.min.js.map b/castle/cms/static/plone-logged-in-compiled.min.js.map