Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE-7265: Add option to disable focus-based interactivity #46

Merged
merged 2 commits into from
Sep 9, 2024
Merged

DE-7265: Add option to disable focus-based interactivity #46

merged 2 commits into from
Sep 9, 2024

Conversation

fingerartur
Copy link
Contributor

@fingerartur fingerartur commented Sep 9, 2024 •
edited
Loading

Here I'm adding an option to disable internal calls to el.focus() which may cause page scroll which may not be desirable in some situations.

@fingerartur fingerartur requested a review from doubeka September 9, 2024 14:32
doubeka
doubeka approved these changes Sep 9, 2024
View reviewed changes
Copy link

@doubeka doubeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, this looks fine.

@fingerartur fingerartur merged commit 820f071 into main Sep 9, 2024
1 check passed
@fingerartur fingerartur deleted the fix/DE-7265-make-focus-optional branch September 9, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doubeka doubeka doubeka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingerartur @doubeka