List of functions from GSW-C #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adressing #61. Let's start with a target list of functions implemented in GSW-C. Maybe mark what was already implemented in Rust.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 81.57% 81.57%
=======================================
Files 6 6
Lines 2008 2008
=======================================
Hits 1638 1638
Misses 370 370 ☔ View full report in Codecov by Sentry. |
castelao
force-pushed
the
missing_list
branch
from
36f4e77
to
6014c89
Compare
Clearly conversions should be the first target.
efiring
reviewed
Nov 28, 2023
Although we don't use it in Rust, since it is explicit by the crate plus module (ex. gsw::earth::distance), let's add it here for consistency.
|
This is not 100% guarantee but it should be a good approximation. The most important here is to guide priorities to what implement next in Rust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #61.
Let's start with a target list of functions implemented in GSW-C. We are missing some functions but also we have a few missing in GSW-C.