Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Feat: Add new functions from #36 #37

Merged
merged 2 commits into from
Mar 21, 2022
Merged

[MRG] Feat: Add new functions from #36 #37

merged 2 commits into from
Mar 21, 2022

Conversation

luizirber
Copy link
Collaborator

@luizirber luizirber commented Mar 20, 2022 •
edited
Loading

TODO:

  • add benchmarks

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2022 •
edited
Loading

Codecov Report

Merging #37 (0e01742) into main (21ba8a3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   81.18%   81.18%           
=======================================
  Files           7        7           
  Lines        1717     1717           
=======================================
  Hits         1394     1394           
  Misses        323      323

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ba8a3...0e01742. Read the comment docs.

luizirber added a commit to luizirber/GSW-C-perf that referenced this pull request Mar 20, 2022
@luizirber
match benchmarks from castelao/GSW-rs#37
26ed322
@luizirber luizirber changed the title [WIP] Feat(ffi): Add new function from #36 [MRG] Feat: Add new functions from #36 Mar 20, 2022
@luizirber luizirber requested a review from castelao March 20, 2022 02:30
castelao
castelao approved these changes Mar 20, 2022
View reviewed changes
Copy link
Owner

@castelao castelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@luizirber luizirber merged commit 7b5c6b5 into main Mar 21, 2022
@luizirber luizirber deleted the lirber/more_ffi branch March 21, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castelao castelao castelao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luizirber @codecov-commenter @castelao