Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make window frameless, update tray info #32

Closed
wants to merge 3 commits into from
Closed

Make window frameless, update tray info #32

wants to merge 3 commits into from

Conversation

aymxdd
Copy link

@aymxdd aymxdd commented May 8, 2017

• Added a tray icon and tray menu to restore the app when "closed"
• Polished the design with a frame less window and some stylised control buttons
• Removed that ugly and useless top menu bar on windows

• Added a tray icon and tray menu to restore the app when "closed"
• Polished the design with a frame less window and some stylised control buttons
• Removed that ugly and useless top menu bar on windows
@cassidoo
Copy link
Owner

cassidoo commented May 9, 2017

One nitpick thing, the whole project uses 2 spaces instead of 4, mind fixing?

2 spaces instead of 4 :)
@farskid
Copy link
Contributor

farskid commented May 10, 2017

The space issue could be solved by adding an .editorconfig file to the root directory of project. Would happily add it if needed.

@aymxdd
Copy link
Author

aymxdd commented May 10, 2017

Yeah you can do it ! I never used a config file for that, I just use beautify on Atom for my indentation :)

@farskid
Copy link
Contributor

farskid commented May 10, 2017

The thing is, linters and config files help, improve consistency across the team :)

@cassidoo
Copy link
Owner

Going to test this on Windows when I get home and review after that. :)

@cassidoo cassidoo changed the title Massive addings Make window frameless, update tray info May 11, 2017
@cassidoo
Copy link
Owner

cassidoo commented May 11, 2017

image

A few issues on Mac.
Tray icon is super large, plus the X and _ buttons on Mac are usually on left. You can also scroll down and not see the buttons. Not sure if a frameless window is the best idea. Plus, if you go for a frameless window, on Windows there still needs to be some way to have a menu. Open to ideas here.

@aymxdd
Copy link
Author

aymxdd commented May 13, 2017

All right, will fix theses issues asap !

Maximized OSX compatibility and some bugfixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants