Skip to content

Commit

Permalink
fix: testing/runner.ts and deno test (denoland/deno#4392)
Browse files Browse the repository at this point in the history
After splitting "failFast" and "exitOnFail" arguments, there was a situation where failing tests did not exit with code 1.

* fixed argument value passed to Deno.runTests() in deno test
* fixed argument value passed to Deno.runTests() in testing/runner.ts
* added integration tests for deno test to ensure failFast and exitOnFail work as expected
* don't write test file to file system, but keep it in memory
  • Loading branch information
bartlomieju authored and denobot committed Feb 1, 2021
1 parent 7893170 commit 9195988
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions testing/runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,16 +269,15 @@ async function main(): Promise<void> {
const exclude =
parsedArgs.exclude != null ? (parsedArgs.exclude as string).split(",") : [];
const allowNone = parsedArgs["allow-none"];
const exitOnFail = parsedArgs.failfast;
const disableLog = parsedArgs.quiet;

try {
await runTestModules({
include,
exclude,
allowNone,
exitOnFail,
disableLog
disableLog,
exitOnFail: true
});
} catch (error) {
if (!disableLog) {
Expand Down

0 comments on commit 9195988

Please sign in to comment.