Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-plugin: fix kotlin compiler args parameter setting #339

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

marcospereira
Copy link
Contributor

Ooops!

There is not much to describe. It was not passing the Kotlin compiler args wrongly as (Java) regular compiler args.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (e8fca09) to head (7f5c585).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #339   +/-   ##
=========================================
  Coverage     91.31%   91.31%           
  Complexity     1218     1218           
=========================================
  Files            76       76           
  Lines          3168     3168           
  Branches        493      493           
=========================================
  Hits           2893     2893           
  Misses          164      164           
  Partials        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@casid
Copy link
Owner

casid commented Apr 5, 2024

Aww, good catch, @marcospereira! Thank you for fixing this.

@casid casid merged commit 376f241 into casid:main Apr 5, 2024
9 checks passed
@marcospereira marcospereira deleted the maven/fix-kotlin-args branch April 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants