Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw token receive #97

Merged
merged 3 commits into from
Jan 18, 2024
Merged

raw token receive #97

merged 3 commits into from
Jan 18, 2024

Conversation

Egge21M
Copy link
Collaborator

@Egge21M Egge21M commented Jan 17, 2024

Description

This adds the capability to receive a raw token instead of only encoded ones to CashuWallet.receive

Changes

  • added some basic parsing logic to check wether parameter is string or Token
  • added test case

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

@Egge21M
Copy link
Collaborator Author

Egge21M commented Jan 17, 2024

Forgot to update JSDoc, will do so asap

@Egge21M
Copy link
Collaborator Author

Egge21M commented Jan 17, 2024

This is now ready for review.

Copy link
Collaborator

@gandlafbtc gandlafbtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@gandlafbtc gandlafbtc merged commit 8dbe219 into cashubtc:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants