Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUT-15] MultiPath Melt Quotes #232

Closed
wants to merge 2 commits into from
Closed

[NUT-15] MultiPath Melt Quotes #232

wants to merge 2 commits into from

Conversation

lollerfirst
Copy link
Contributor

@lollerfirst lollerfirst commented Dec 28, 2024 •
edited
Loading

Description

Can now generate quotes aimed to pay for only a portion of an invoice.

Changes

  • added createMultiPathMeltQuote which returns a MeltQuoteResponse
  • modified MeltQuotePayload to support options for mpp amounts.
  • TODO: test with regtest

PR Tasks

  • Open PR
  • run npm run test --> no failing unit tests
  • run npm run format

@lollerfirst
Copy link
Contributor Author

lollerfirst commented Dec 28, 2024 •
edited
Loading

Has anybody tried to run calle's regtest?
I wanted to extend it to add multiple Mints on top of each lightning node but It doesn't seem to be working as it is and I can't figure out why.

@Egge21M
Copy link
Collaborator

Egge21M commented Dec 28, 2024

@lollerfirst did you see this? #208

@lollerfirst
Copy link
Contributor Author

Woopsie...

@lollerfirst
Copy link
Contributor Author

@Egge21M Although this is more in line with the redesign you've been advocating for recently. It has a new createMultiPathMeltQuote as opposed to adding options to an existing method. Should I reopen it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lollerfirst @Egge21M