Use cashu crypto library functions, remove dhke and secrets module #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capitalist42
force-pushed
the
use-cashu-crypto-library
branch
from
c30fe27 to
32dbd12
Compare
capitalist42
force-pushed
the
use-cashu-crypto-library
branch
from
32dbd12 to
00c2b08
Compare
gandlafbtc
approved these changes
May 21, 2024
| @@ -682,6 +690,31 @@ class CashuWallet { | |||
| const { blindedMessages, rs, secrets } = this.createBlindedMessages(amounts, keysetId, counter); | |||
| return { blindedMessages, secrets, rs }; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
It would probably make sense to move this to the cashu-crypto lib too. We can do it in a later PR though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All functions related to BDHKE and restoring signatures (from secrets) were copied to the "@cashu/crypto" library.
This pull request aims to refactor code to use functions from the library.
...
Changes
PR Tasks
npm run test--> no failing unit testsnpm run format