Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComposeUI layouts aren’t consistent with Android Views or iOS UIViews #2367

Open
swankjesse opened this issue Oct 4, 2024 · 0 comments
Open

ComposeUI layouts aren’t consistent with Android Views or iOS UIViews #2367

swankjesse opened this issue Oct 4, 2024 · 0 comments
Labels
redwood/layout toolkit/composeui

Comments

@swankjesse
Copy link
Collaborator

We’re not consistent between ComposeUI and other layout implementations. This is best observed in the screenshot tests.
@swankjesse swankjesse mentioned this issue Oct 4, 2024
Merged
luis-cortes added a commit to luis-cortes/redwood that referenced this issue Nov 21, 2024
@luis-cortes
Applying padding modifier after background modifier
70fe1ca 
Relates to cashapp#2367

In compose ui, modifier order matters and applying padding before a background prevents the background from filling the box.
luis-cortes added a commit to luis-cortes/redwood that referenced this issue Nov 21, 2024
@luis-cortes
Fix inconsistency in margin application between ComposeUiBox and `V…
f1da3b0 
…iewBox`

Relates to cashapp#2367

In compose ui, modifier order matters and applying padding before a background prevents the background from filling the box.
@luis-cortes luis-cortes mentioned this issue Nov 21, 2024
Merged
1 task
JakeWharton pushed a commit that referenced this issue Nov 21, 2024
@luis-cortes
Fix inconsistency in margin application between ComposeUiBox and `V…
365b927 
…iewBox` (#2478)

Relates to #2367

In compose ui, modifier order matters and applying padding before a background prevents the background from filling the box.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
redwood/layout toolkit/composeui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swankjesse