Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue "Error Range start 5 is out of text of length 1 #136" #149

Conversation

gokberkbar
Copy link

The solution was already implemented in your code but it was commented out.

I tested every scenario could not find any bug.

What was the issue that you fixed by commenting this out? @caseyryan

@gokberkbar gokberkbar changed the title fix fix for issue "Error Range start 5 is out of text of length 1 #136" Nov 27, 2023
@gokberkbar
Copy link
Author

I noticed that you changed the plugins version to 2.11.2 to 2.11.4 and in your CHANGELOG.md you have a description says "- Fixed a bug with incorrect decimal point detection when mantissa length is 0".
However because of this String? fractionalSeparator = _detectFractionSeparator(value); you have a bug with mantissa length being 0.

After changes the issue with mantissa length being zero and also Issue 134 is fixed.

It is an issue for production code. That would be great for us if you can take a look and release this version. @caseyryan

Thanks

@caseyryan
Copy link
Owner

I noticed that you changed the plugins version to 2.11.2 to 2.11.4 and in your CHANGELOG.md you have a description says "- Fixed a bug with incorrect decimal point detection when mantissa length is 0". However because of this String? fractionalSeparator = _detectFractionSeparator(value); you have a bug with mantissa length being 0.

After changes the issue with mantissa length being zero and also Issue 134 is fixed.

It is an issue for production code. That would be great for us if you can take a look and release this version. @caseyryan

Thanks

The issue in this case was because of a period used as a thousand separator. double.tryParse() accepted it as a fractional part.
The ones you mentioned above are different

@caseyryan caseyryan closed this Nov 27, 2023
@gokberkbar gokberkbar deleted the hotfix/mantissa-lenght-0-and-thausand-separator-period branch November 27, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants