Padding implementation

[martijn00]

Connection with issue(s)

Connected to #6

Solution description

Once PR 6 is merged in i'll rebase this so the rest is gone.

I've now set the values the a double? type, but the disadvantage of this is that you cannot let every direction calculate its own value. Say i want a Gutter.medium top and bottom, which would use the default material value, but i want a left and right gutter.small(scaleFactor = 4). That is why i put the Gutter widget in.

Using Gutter:

const GutterPadding.all(
    value: Gutter.medium(),
    child: ColoredBox(color: Colors.blue, child: Text('Child')),
),

const GutterPadding.only(
    left: Gutter.medium(),
    right: Gutter.small(),
    top: Gutter(size: 20),
    bottom: Gutter.medium(scaleFactor: 3),
    child: ColoredBox(color: Colors.blue, child: Text('Child')),
),

Using double? as parameter:

const GutterPadding.all(
    value: context.gutterSize(
      type: GutterType.medium,
    ),
    child: ColoredBox(color: Colors.blue, child: Text('Child')),
),

const GutterPadding.only(
    left: null,
    right: context.gutterSize(
      type: GutterType.small,
    ),
    top: context.gutterSize(
      type: GutterType.medium,
      size: 20
    ),
    bottom: context.gutterSize(
      type: GutterType.medium,
      scaleFactor: 3
    ),
    child: ColoredBox(color: Colors.blue, child: Text('Child')),
),

Screenshots or Videos

To Do

• Check the original issue to confirm it is fully satisfied
• Add solution description to help guide reviewers
• Add unit test to verify new or fixed behavior
• If apply, add documentation to code properties and package readme

[caseycrogers]

Aww I see there were some other changes here too.

In the old version I could do: context.gutter, context.gutterSmall etc and directly get the double value of the gutter. It feels to me like context.gutterSize() and GutterType are really more of implementation details and are pretty clunky to use as a part of the external API.

Can we go back to directly exposing context.gutterSmall etc and remove gutterSize or make it a private implementation detail? It'll make the source code a bit more tedious but it'll make the external API dramatically more intuitive and easy to use.

[caseycrogers]

Also, in T-minus 3 hours I'll be unreachable for a week so maybe it's best we table this and I get back to you after?

[martijn00]

@caseycrogers sure, no worries. Let me know when you are back and we'll discuss it further. I'll close this PR and continue any work in #6