Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump prerelease pointers #259

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Bump prerelease pointers #259

merged 5 commits into from
Nov 28, 2023

Conversation

ajnelson-nist
Copy link
Member

No description provided.

A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#563

Signed-off-by: Alex Nelson <[email protected]>
References:
* ucoProject/UCO#563

Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <[email protected]>
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#562

Signed-off-by: Alex Nelson <[email protected]>
References:
* ucoProject/UCO#562

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist
Copy link
Member Author

I'm fine with this merging once CI passes.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review November 22, 2023 23:53
@ajnelson-nist ajnelson-nist requested a review from a team as a code owner November 22, 2023 23:53
Copy link
Contributor

@plbt5 plbt5 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajnelson-nist :

I'd suggest to improve the documentation and assure that each triple's Subject is provided with one of the textual properties (sh:message, rdfs:comment, rdfs:seeAlso, ...), providing some description of the Subject. For instance, lines 1034-1041 specify the datatype-objects shape, but I need to read the code to understand its working.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair feedback! I'm porting it over to UCO Issue 562.

@plbt5 plbt5 merged commit c312c22 into master Nov 28, 2023
1 check passed
@plbt5 plbt5 deleted the bump_prerelease_pointers branch November 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants