fix: Modify the way of parse and validate mongo url #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoaringTiger
force-pushed
the
fix-check-url-bug
branch
from
46d9ea7
to
a2353e1
Compare
SoaringTiger
changed the title
Signed-off-by: SoaringTiger <[email protected]>
SoaringTiger
force-pushed
the
fix-check-url-bug
branch
from
a2353e1
to
c616e87
Compare
Signed-off-by: SoaringTiger <[email protected]>
SoaringTiger
force-pushed
the
fix-check-url-bug
branch
from
f01db1d
to
f52750f
Compare
|
@closetool plz review. |
kilosonc
approved these changes
Mar 20, 2021
|
@closetool plz make a new release. |
|
@hsluoyz sorry, but I have no permission |
|
@closetool try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #39
There is an mongodb official package "go.mongodb.org/mongo-driver/x/mongo/driver/connstring" will solve it.
And databaseName just use connString.Database value.