Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revert "feat: fix the comma separater bug" #431

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

hsluoyz
Copy link
Member

@hsluoyz hsluoyz commented Oct 7, 2024

Reverts #408

Fix: #430

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.92%. Comparing base (f49fddb) to head (78067c3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #431      +/-   ##
==========================================
- Coverage   68.01%   67.92%   -0.10%     
==========================================
  Files          55       55              
  Lines        2745     2734      -11     
  Branches      510      508       -2     
==========================================
- Hits         1867     1857      -10     
  Misses        724      724              
+ Partials      154      153       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hsluoyz hsluoyz merged commit 89b4c56 into master Oct 7, 2024
4 of 5 checks passed
Copy link

github-actions bot commented Oct 7, 2024

🎉 This PR is included in version 1.68.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] || replaced with comma in policy fields
3 participants