-
Notifications
You must be signed in to change notification settings - Fork 9
fix: Update dependencies, ensure build success and add axum-middleware-example #72
Conversation
@smrpn @hackerchai @PsiACE @GopherJ please review |
@hackerchai do I need to do anything else? |
@hackerchai plz review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SiddheshKanawade Can you also add pull request github actions to run build checks? |
@hackerchai I have added the pull_request check and also the cache, not sure the cache will work or not, last time it didn't worked |
@SiddheshKanawade plz fix: |
The above commits ensures that In actix-middleware-example, there are various version conflicts that I am trying to resolve(some examples below). Any suggestions on how should I resolve them? Also, the depedencies shown for actix-casbin-auth aren't updated in crates.io, I think this might be the issue(not sure though). It says that v3 of actix-web is used and not v4. |
The possible cure here could be to match the versions of the dependencies to that of the crate.io but then it would restrict us to update the dependencies |
please fix |
Yeah, I am working on it, its probably due to two different versions of tokio |
The crates.io don't have the versions of the dependencies updated, thus had to do following change to allow the use of newer versions of the actix dependencies without conflict actix-casbin= {git = "https://github.com/casbin-rs/actix-casbin", default-features = false, features = [ "runtime-async-std" ]}
actix-casbin-auth = {git = "https://github.com/casbin-rs/actix-casbin-auth", default-features = false, features = [ "runtime-async-std" ]} To actix-casbin= {version = "0.4.2", default-features = false, features = [ "runtime-async-std" ]}
actix-casbin-auth = {version = "0.4.4", default-features = false, features = [ "runtime-async-std" ]} This needs to be updated ones versions are updated in crates.io |
@hackerchai I need to get PR #25 merged, so that we have updated tokio version in actix-casbin and avoid the tokio version conflict here. Also, I have completed my work on this PR and can be reviewed once the above mentioned PR gets merged. |
@SiddheshKanawade plz fix the CI errors |
@hackerchai All of the tasks have been completed and all checks are passing, kindly review and let me know if I need to do anything else |
@SiddheshKanawade plz don't make so big and long-term PRs. You should not make just one PR for the whole summer and put everything in it. Our community's PRs are expected to be small-scale and will be reviewed & merged within 2-3 days, at most one week ideally. |
Yeah, actually this repository had a lot to do before I can make build run, so initially the PR became long. Also, this was what I was planning to do initially, but as per instructed by my mentor, I switched to axum-casbin-auth and hence this PR got extended. When I switched back to the task, rather than opening a new PR, I continued to work on this rather than closing it. |
OK. @hackerchai plz review and get this one merged ideally |
Since now we have refactored this repository into smaller repositories, this PR has no significance and hence closing it. |
Planned to ensure build with dependencies updated to latest version. Also add axum-middleware-example.
TODO:
actix-fileadapter-rbac
compile successfully after updating the dependenciesactix-middleware-example
ntex-fileadapter-acl
solved #71