-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional boolean to not escape html during json encoding #891
Conversation
6d93e42
to
95154b9
Compare
checking. |
There's no other option on the json Encoder, only |
95154b9
to
8c01e05
Compare
I've fixed the tests and created one for the new feature. |
4bf88c3
to
b5de38f
Compare
ignore my previous comment, I think I had a brain fade moment there. I feel it is better to name the variable as escape_html with the default value as true, which will be inline with what json encoder is doing. someone intending to not escape html can set it as escape_html=false |
b5de38f
to
0d78e1e
Compare
@cppforlife @100mik please have a look at this when you get time. |
@WnP also could you please check the lint failure when you get time. |
Signed-off-by: Steeve Chailloux <[email protected]>
0d78e1e
to
cc432b6
Compare
Sorry for the delay @prembhaskal, I was quite busy during the last days. Feel free to ping me if there's something missing. |
LGTM, |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #890