Add annotation positions to schema error messages #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gcheadle-vmware
commented
Nov 24, 2021
gcheadle-vmware
commented
- only implemented on syntax errors when creating schema
gcheadle-vmware
force-pushed
the
schema-annotation-postions
branch
from
f04a5a2 to
cf97145
Compare
pivotaljohn
reviewed
Nov 24, 2021
Comment on lines
+150
to
+151
| annPositions []*filepos.Position | ||
| position *filepos.Position |
There was a problem hiding this comment.
Is it possible to merge these into a single slice of Positions? I dug in a bit and it looked feasible.
If we could, it would simplify a bunch of code.
|
Still wanting to follow up on the error output case for multiple file names within a slice of positions. |
pivotaljohn
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.