Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Empty data values is struct instead of None #431

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

cari-lynn
Copy link
Contributor

In v.0.31.0 we changed the type of an empty data values to be None, this PR changes it back to what it was previously: a struct.

cari-lynn and others added 2 commits June 14, 2021 11:10
- prevent nil as value for dv doc

Signed-off-by: Garrett Cheadle <[email protected]>
Copy link
Contributor

@pivotaljohn pivotaljohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nice lagniappe: collocating newEmptyDataValuesDocument() alongside NewEmptyDataValues().

@pivotaljohn pivotaljohn merged commit 35644b1 into develop Jun 15, 2021
@cari-lynn cari-lynn deleted the empty-data-values branch June 21, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants