Data values files #398
Merged
Data values files #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppforlife
force-pushed
the
data-values-files
branch
from
7a7d917 to
706e81c
Compare
pivotaljohn
reviewed
May 26, 2021
pivotaljohn
reviewed
May 28, 2021
cppforlife
force-pushed
the
data-values-files
branch
2 times, most recently
from
2a43750 to
c76e1e0
Compare
added 2 commits
May 28, 2021 15:45
removes + suffix feature for cmdline data values that was used to explicitly mark key as missing_ok=True
cppforlife
force-pushed
the
data-values-files
branch
from
c76e1e0 to
1f89148
Compare
|
updated HasTemplating() to accept yamlmeta.Node. looks better! |
|
This looks great to me. The conversation about organizing tests really ought to take into account all Thank you for your contribution, Mr. Kalinin. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still in draft.
implements this proposal: https://github.com/vmware-tanzu/carvel-community/tree/develop/proposals/ytt/002-raw-data-values for #381
this PR also:
or_add=Trueto@overlay/replaceso that when map key does not match, replace would fallback to just adding map item