Skip to content

Commit

Permalink
Remove redundant go fmt/mod-vendor/mod-tidy
Browse files Browse the repository at this point in the history
This script was running `go fmt` over the `yaml.v2` package as well.
That code is manually vendored and should not be changed, incidentally.

Note that this script runs ./hack/build.sh.
That script runs `go fmt` _excluding_ the `yaml.v2` package.
It also runs the `go mod...` commands removed here.

When Go is upgraded, sometimes this means that `go fmt` produces
different output. It does for Go 1.19.

Fixes: https://github.com/vmware-tanzu/carvel-ytt/actions/runs/3625263105
  • Loading branch information
pivotaljohn committed Dec 6, 2022
1 parent 4847d0b commit 7dc9e00
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions hack/build-binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ function get_latest_git_tag {

VERSION="${1:-`get_latest_git_tag`}"

go fmt ./cmd/... ./pkg/... ./test/...
go mod vendor
go mod tidy

# makes builds reproducible
export CGO_ENABLED=0
LDFLAGS="-X github.com/vmware-tanzu/carvel-ytt/pkg/version.Version=$VERSION"
Expand Down

0 comments on commit 7dc9e00

Please sign in to comment.