Skip to content

Commit

Permalink
Update CI to use Go 1.17
Browse files Browse the repository at this point in the history
- bump goreleaser to avoid bug when building darwin/arm64 with go version 1.17
  - goreleaser/goreleaser#2412
  • Loading branch information
jtigger committed Feb 25, 2022
1 parent f7e9672 commit 3a9345a
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.16.0
go-version: 1.17.0

- name: generate website/generate.go
if: startsWith(github.ref, 'refs/tags/')
Expand All @@ -32,7 +32,7 @@ jobs:
uses: goreleaser/goreleaser-action@5e15885530fb01d81d1f24e8a6f54ebbd0fed7eb
if: startsWith(github.ref, 'refs/tags/')
with:
version: 0.162.0
version: 0.181.1
args: release --rm-dist --debug
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v1
with:
go-version: "1.16"
go-version: "1.17"
- name: Check out code into the Go module directory
uses: actions/checkout@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v1
with:
go-version: "1.16"
go-version: "1.17"
- name: Check out code into the Go module directory
uses: actions/checkout@v2
- name: Run Tests
Expand Down
5 changes: 1 addition & 4 deletions pkg/yttlibrary/url.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,7 @@ func (b urlModule) QueryParamsDecode(thread *starlark.Thread, f *starlark.Builti
// - particularly https://github.com/golang/go/issues/25192#issuecomment-789799446 which spells-out the vulnerability
// specifically.
func (b urlModule) allowQuerySemicolons(encodedVal string) string {
if strings.Contains(encodedVal, ";") {
return strings.ReplaceAll(encodedVal, ";", "&")
}
return encodedVal
return strings.ReplaceAll(encodedVal, ";", "&")
}

func (b urlModule) sortedKeys(vals url.Values) []string {
Expand Down

0 comments on commit 3a9345a

Please sign in to comment.