Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hg] fault tolerant commit sha resolution #168

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

WnP
Copy link
Contributor

@WnP WnP commented Jun 28, 2022

if terminfo is wrongly configured hg id -i --debug can return the following errors:

no terminfo entry for invis
no terminfo entry for blink
no terminfo entry for invis
no terminfo entry for blink
no terminfo entry for invis

Which causes vendir to fail to retrieve the commit sha.

Using hg log -r . -T '{node}' returns the same result and solves this issue.

@cppforlife cppforlife merged commit 487d16c into carvel-dev:develop Jun 28, 2022
@cppforlife
Copy link
Contributor

will try to cut a release shortly (seeing if we can merge another open PR before that)

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Jun 28, 2022
@cppforlife
Copy link
Contributor

@WnP
Copy link
Contributor Author

WnP commented Jun 30, 2022

Thanks a lot @cppforlife

@cppforlife
Copy link
Contributor

ill share release glory with @DennisDenuto :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-triage This issue has not yet been reviewed for validity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants