Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont set IMGPKG_ANON when no auth is explicitly given #141

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

cppforlife
Copy link
Contributor

removal of this allow imgpkg to use other auth methods; this is inline with allowing git fetcher to use its regular auth mechanisms even though they are not explicitly called out in vendir.yml

removal of this allow imgpkg to use other auth methods; this is inline with allowing git fetcher to use its regular auth mechanisms even though they are not explicitly called out in vendir.yml
@cppforlife cppforlife force-pushed the remove-imgpkg-anon-auth branch from 09fb3a3 to fd3c1c9 Compare March 10, 2022 13:46
@davidreuss
Copy link

Works like a charm! ⭐

❯ ~/Code/vmware-tanzu/carvel-vendir/vendir sync
Fetching: vendor + dreuss/imgpkg-demo (imgpkgBundle from gcr.io/$gcr_private_project/imgpkg-demo:test)

Lock config

apiVersion: vendir.k14s.io/v1alpha1
directories:
- contents:
  - imgpkgBundle:
      image: gcr.io/$gcr_private_project/imgpkg-demo@sha256:a05cd4917f9b48b57f872feeaeee2adffe746713bffad5ce4fa0e5c55e964b35
      tag: test
    path: imgpkg-demo
  path: vendor
kind: LockConfig

Succeeded

Slack thread on carvel channel in kubernetes slack workspace for reference.

@cppforlife cppforlife merged commit 1655a8e into develop Mar 10, 2022
@benmoss benmoss deleted the remove-imgpkg-anon-auth branch March 10, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants