Merge pull request #391 from Zebradil/389-fix-panic

fix: avoid panic by checking response for nil
carvel-dev · Jul 24, 2024 · 0c8f01a · 0c8f01a
2 parents 1ccbd25 + a1f83af
commit 0c8f01a
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/pkg/vendir/fetch/githubrelease/sync.go b/pkg/vendir/fetch/githubrelease/sync.go
@@ -244,11 +244,13 @@ func (d Sync) fetchTagSelection() (string, error) {
 		tagList, resp, err := d.client.Repositories.ListTags(context.Background(), ownerName, repoName, &listOpt)
 		if err != nil {
 			errMsg := err.Error()
-			switch resp.StatusCode {
-			case 401, 403:
-				hintMsg := "(hint: consider setting VENDIR_GITHUB_API_TOKEN env variable to increase API rate limits)"
-				bs, _ := io.ReadAll(resp.Body)
-				errMsg += fmt.Sprintf(" %s (body: '%s')", hintMsg, bs)
+			if resp != nil {
+				switch resp.StatusCode {
+				case 401, 403:
+					hintMsg := "(hint: consider setting VENDIR_GITHUB_API_TOKEN env variable to increase API rate limits)"
+					bs, _ := io.ReadAll(resp.Body)
+					errMsg += fmt.Sprintf(" %s (body: '%s')", hintMsg, bs)
+				}
 			}
 			return "", fmt.Errorf("Downloading tags info: %s", errMsg)
 		}
@@ -433,7 +435,7 @@ func (d Sync) authToken() (string, error) {
 		}
 	}
 
-	return token, nil
+	return strings.TrimSpace(token), nil
 }
 
 type ReleaseAPI struct {